Ability to preserve primary key type #390
Open
+70
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
According to MeiliSearch docs
However, currently meilisearch-rails always stringifies primary keys before sending them to MeiliSearch. As a result, sorting by primary key becomes impossible, because hits will be sorted alphabetically:
What does this PR do?
Ideally full test suite will have to be ran twice, with this config set to true and false; I did so manually when submitting this PR. But I wasn't sure if this PR will be considered so didn't expand specs, other than adding a test which confirms that primary-key-sorted docs will preserve order.
PR checklist
Please check if your PR fulfills the following requirements: